Fix load files in directory with *git* prefix #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @msAlcantara, Whenever possible, do your PR on the develop branch please. Thx |
|
Ok, sorry about that, and I closed PR it unintentionally too. |
5cbea45 to
27dfb40
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was a problem?
Insider don't load files in repository if your name contains *git*, like username.github.io
How this PR fixes the problem?
This PR change the regex to ignore .git/ and allow **.git** folders, but I'think that we should improvement the mechanism of load files that need to be analyzed.
This PR also includes regex changes to include javascript files in the validation (other types of files were being included in the validation)