-
Notifications
You must be signed in to change notification settings - Fork 5.7k
fix(agent): Handle nil timer on telegraf reload when no debounce is specified #17373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@neelayu Thanks for the PR! I reviewed the code and see the issue:
If debounce is disabled, Suggestion: if reloadTimer != nil {
reloadTimer.Stop()
} This ensures safe handling regardless of debounce config or shutdown path. |
@skartikey |
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@neelayu Thanks!
Summary
Telegraf was crashing on watch reload. A condition to check if the timer is not nil is added.
Checklist
Related issues
resolves #17372