Skip to content

fix(processors.strings): Add explicit TOML tags on struct fields #17210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

fix(processors.strings): Add explicit TOML tags on struct fields #17210

merged 1 commit into from
Jun 23, 2025

Conversation

skartikey
Copy link
Contributor

Summary

When struct fields don’t have explicit TOML tags, the TOML library uses the field names directly for mapping. However, it can only access exported fields (i.e., those starting with a capital letter).

In this case, the fields are unexported (lowercase), so the TOML parser can’t see them, which leads to the error:

configuration specified the fields ["new" "tag" "old"], but they were not used

That's why these fields need to be exported or have proper TOML tags to be recognized.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #17208

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/processor labels Jun 18, 2025
@cschug cschug mentioned this pull request Jun 18, 2025
Closed
@skartikey skartikey force-pushed the processors_strings_fix branch from c24078f to 6973c39 Compare June 19, 2025 12:43
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

srebhan
srebhan approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skartikey!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 20, 2025
@srebhan srebhan removed their assignment Jun 20, 2025
@mstrandboge mstrandboge merged commit e2cd9cf into influxdata:master Jun 23, 2025
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.35.1 milestone Jun 23, 2025
srebhan pushed a commit that referenced this pull request Jun 23, 2025
@skartikey @srebhan
fix(processors.strings): Add explicit TOML tags on struct fields (#17210
c760e3f 
)

(cherry picked from commit e2cd9cf)
This was referenced Jun 25, 2025
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@mstrandboge mstrandboge mstrandboge approved these changes

Assignees

@mstrandboge mstrandboge

Labels
fix pr to fix corresponding bug plugin/processor ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.35.1
Development

Successfully merging this pull request may close these issues.

processors.strings.replace no longer works in 1.35.0
3 participants
@skartikey @srebhan @mstrandboge