Skip to content

fix(inputs.gnmi): Avoid interpreting path elements with multiple colons as namespace #17285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2025
Merged

fix(inputs.gnmi): Avoid interpreting path elements with multiple colons as namespace #17285

merged 1 commit into from
Jul 3, 2025

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Jul 2, 2025

Summary

The current code splits every path element at the first colon interpreting the part before as namespace. However, MAC addresses or IPv6 addresses might contain colons and as a consequence the first group will be stripped in paths.

This PR fixes the issue by leaving alone path element with multiple colons.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #17279

@srebhan srebhan self-assigned this Jul 2, 2025
@telegraf-tiger telegraf-tiger bot added area/gnmi fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jul 2, 2025
@srebhan srebhan mentioned this pull request Jul 2, 2025
Closed
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jul 2, 2025

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

. DEB . RPM . TAR . GZ . ZIP
[[amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip] [arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip] [armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip] [armhf.deb i386.rpm freebsd_armv7.tar.gz ] [i386.deb ppc64le.rpm freebsd_i386.tar.gz ] [mips.deb riscv64.rpm linux_amd64.tar.gz ] [mipsel.deb s390x.rpm linux_arm64.tar.gz ] [ppc64el.deb x86_64.rpm linux_armel.tar.gz ] [riscv64.deb linux_armhf.tar.gz ] [s390x.deb linux_i386.tar.gz ] [ linux_mips.tar.gz ] [ linux_mipsel.tar.gz ] [ linux_ppc64le.tar.gz ] [ linux_riscv64.tar.gz ] [ linux_s390x.tar.gz ]]

@srebhan srebhan assigned skartikey and mstrandboge and unassigned srebhan Jul 3, 2025
skartikey
skartikey approved these changes Jul 3, 2025
View reviewed changes
Copy link
Contributor

@skartikey skartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change ensures that only elements with exactly one colon are treated as namespace:identifier pairs. Elements with multiple colons (like MAC addresses or IPv6 addresses) are left intact.

@skartikey skartikey removed their assignment Jul 3, 2025
@skartikey skartikey added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 3, 2025
@mstrandboge mstrandboge merged commit 647a162 into influxdata:master Jul 3, 2025
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.35.2 milestone Jul 3, 2025
srebhan added a commit that referenced this pull request Jul 7, 2025
@srebhan
fix(inputs.gnmi): Avoid interpreting path elements with multiple colo…
4e78e28 
…ns as namespace (#17285)

(cherry picked from commit 647a162)
@BrewTestBot BrewTestBot mentioned this pull request Jul 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skartikey skartikey skartikey approved these changes

@mstrandboge mstrandboge mstrandboge approved these changes

Assignees

@mstrandboge mstrandboge

Labels
area/gnmi fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.35.2
Development

Successfully merging this pull request may close these issues.

gNMI plugin incorrectly truncates MAC addresses in field names
3 participants
@srebhan @skartikey @mstrandboge