fix(outputs): Retrigger batch-available-events correctly #17246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowjoel
reviewed
Jul 2, 2025
mstrandboge
approved these changes
Jul 4, 2025
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
skartikey
approved these changes
Jul 7, 2025
srebhan
added a commit
that referenced
this pull request
Jul 7, 2025
(cherry picked from commit 82d0f5c)
|
Warning, we had influxDb turned in for a output that wasn't connected and since now it doesn't wait for the write to finish was filling our logs and machine resources with metrics logs that couldn't find a host. This fix might be a problem for when you are having errors in the service |
|
@andrev10 you're right, I saw it in my machine too. Can you open another issue documenting this? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The current code triggers a
Writefor an output as soon as a batch becomes available. This is done via theBatchReadychannel and as a consequence the agent will call the write which then writes all available batches to quickly empty the buffer.However, when adding metric during the time we write, the code becomes "racy" because we are resetting
newMetricsCountafter finishing the write which will neglect the fact that metrics were added during the write. As a consequence, you always need to add a complete batch after the write finishes (or wait for the flush interval) to trigger another write. This is an issue if metrics are added in bursts much larger than the batch size.This PR removes the redundant book-keeping and relies on the buffer fullness to determine if a new batch is available. As such we use the buffer as a single place of truth. To avoid causing trigger storms we avoid retriggering a write if there is one in progress.
Checklist
Related issues
resolves #17200