Skip to content

feat(inputs.amqp_consumer): Allow string values in queue arguments #17121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

feat(inputs.amqp_consumer): Allow string values in queue arguments #17121

merged 1 commit into from
Jun 10, 2025

Conversation

mattbaron
Copy link
Contributor

@mattbaron mattbaron commented Jun 7, 2025 •
edited
Loading

Summary

Mirrored classic queues are deprecated in RabbitMQ 4.0.x and are removed in 4.1.x, leaving quorum queues as the only option for clustering. In order for the amqp_consumer plugin to create or read from a quorum queue it needs to have the following (string) queue argument:

queue_arguments = {"x-queue-type" = "quorum"}

This is not currently possible as the queue arguments functionality was coded to only accept int values.

This PR will enable both int and string values to be passed in queue_arguments.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves 17120
resolves 6591

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jun 7, 2025

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jun 7, 2025
@mattbaron
Copy link
Contributor Author

!signed-cla

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jun 7, 2025

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@mattbaron
Copy link
Contributor Author

mattbaron commented Jun 7, 2025 •
edited
Loading

My PR relates to the amqp_consumer input, and the test for the stackdriver output on windows (only) failed. It seems like there is an issue with this test, maybe a time related race condition. I don't think there is anything I've done in my PR that caused this failure and I don't think there is anything I can do in my PR to resolve it.

Please advise.

image

srebhan
srebhan approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks @mattbaron!

@srebhan srebhan added area/rabbitmq ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Jun 10, 2025
@mstrandboge mstrandboge merged commit 106bfee into influxdata:master Jun 10, 2025
36 of 37 checks passed
@github-actions github-actions bot added this to the v1.35.0 milestone Jun 10, 2025
skartikey pushed a commit to skartikey/telegraf that referenced this pull request Jun 13, 2025
@mattbaron @skartikey
feat(inputs.amqp_consumer): Allow string values in queue arguments (i…
455f23c 
…nfluxdata#17121)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@mstrandboge mstrandboge mstrandboge approved these changes

Assignees

@skartikey skartikey

@mstrandboge mstrandboge

Labels
area/rabbitmq feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.35.0
Development

Successfully merging this pull request may close these issues.

amqp_consumer input plugin: Support quorum queues amqp_consumer input plugin support for quorum queues (RabbitMQ 3.8)
4 participants
@mattbaron @srebhan @mstrandboge @skartikey