fix(inputs.procstat): Fix user filter conditional logic #17178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic is incorrect. Currently, it will continue (skip the process) when: username != "" (username is not empty) OR !f.filterUser.Match(username) (username doesn't match the filter) This means it will skip processes even when they have valid usernames that DO match the filter, which is likely not what we want.
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
mstrandboge
approved these changes
Jun 18, 2025
srebhan
pushed a commit
that referenced
this pull request
Jun 23, 2025
(cherry picked from commit 9e9bbc5)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Filter by users conditional logic is incorrect. Currently, it will continue (skip the process) when:
username != ""(username is not empty) OR!f.filterUser.Match(username)(username doesn't match the filter)This means it will skip processes even when they have valid usernames that DO match the filter, which is likely not what we want.
Checklist
Related issues
resolves #