Skip to content

fix(inputs.cloudwatch): Restore filtering to match all dimensions #17009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2025
Merged

fix(inputs.cloudwatch): Restore filtering to match all dimensions #17009

merged 1 commit into from
May 19, 2025

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented May 16, 2025

Summary

PR #16337 changed the dimension filtering and by doing so accidentally changed the filter behavior to accept all "unconfigured" dimensions. This however, leads to the artifact that users are no longer able to exclude dimension to e.g. query data accumulated over availability zones.

This PR restores the pre-v1.34.0 behavior and will only accept metrics that match all configured dimensions i.e. excluding metrics with dimensions not configured by the user.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #17001

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels May 16, 2025
@srebhan srebhan mentioned this pull request May 16, 2025
Closed
@srebhan srebhan self-assigned this May 16, 2025
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan assigned skartikey and mstrandboge and unassigned srebhan May 16, 2025
@mstrandboge mstrandboge removed their assignment May 16, 2025
@mstrandboge mstrandboge added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 16, 2025
@skartikey skartikey merged commit d29d849 into influxdata:master May 19, 2025
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.34.4 milestone May 19, 2025
srebhan added a commit that referenced this pull request May 19, 2025
@srebhan
fix(inputs.cloudwatch): Restore filtering to match all dimensions (#1…
9bb9a5c 
…7009)

(cherry picked from commit d29d849)
@BrewTestBot BrewTestBot mentioned this pull request May 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skartikey skartikey skartikey approved these changes

@mstrandboge mstrandboge mstrandboge approved these changes

Assignees

@skartikey skartikey

Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.34.4
Development

Successfully merging this pull request may close these issues.

Change in behavior between 1.33 and 1.34 - Additional cloudwatch labels are introduced
3 participants
@srebhan @skartikey @mstrandboge