fix(inputs.lustre2): getLustreProcStats skips empty files #16911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for the pull request! |
|
!signed-cla |
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
This avoids an "index out of range" when trying to figure out if the data should be tagged with job_id here Refs: influxdata#16631
b734a8b to
ecec57f
Compare
skartikey
approved these changes
Apr 30, 2025
|
@alexvkempen Thanks for your contribution! |
srebhan
pushed a commit
that referenced
this pull request
May 5, 2025
Co-authored-by: Alexandre Van Kempen <alexandre.vankempen@qarnot-computing.com> (cherry picked from commit 26e1f35)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
From Lustre2.16 some stats files (e.g. /proc/fs/lustre/mdt/*/job_stats) can be completely empty, whereas in previous versions there were always at least some characters at the beginning of the file (e.g. "job_stats: ")
getLustreProcStatsgenerates an "index out of range" crash when trying to "figure out if the data should be tagged with job_id" if the file is completely empty.This fix enables to skip empty files as there is nothing to report anyway.
Checklist
Related issues
resolves #16631