Skip to content

fix(inputs.win_eventlog): Handle large events to avoid they get dropped silently #16815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 15, 2025
Merged

fix(inputs.win_eventlog): Handle large events to avoid they get dropped silently #16815

merged 3 commits into from
May 15, 2025

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Apr 17, 2025

Summary

This PR allows to handle arbitrarily large events but introduces a event_size_limit to prevent denial-of-service situations when really large events occur. Furthermore, now an error message is logged if the message is too large so that there is at least a trace in the logs.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16381

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 17, 2025
@srebhan srebhan mentioned this pull request Apr 17, 2025
Closed
@srebhan srebhan self-assigned this Apr 23, 2025
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan added the area/windows Related to windows plugins (win_eventlog, win_perf_counters, win_services) label May 7, 2025
@srebhan srebhan assigned skartikey and mstrandboge and unassigned srebhan May 7, 2025
skartikey
skartikey approved these changes May 9, 2025
View reviewed changes
Copy link
Contributor

@skartikey skartikey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@srebhan Looks perfect!

@skartikey skartikey removed their assignment May 9, 2025
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 14, 2025
@mstrandboge mstrandboge merged commit ddf23e3 into influxdata:master May 15, 2025
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.34.4 milestone May 15, 2025
srebhan added a commit that referenced this pull request May 19, 2025
@srebhan
fix(inputs.win_eventlog): Handle large events to avoid they get dropp…
e56de4e 
…ed silently (#16815)

(cherry picked from commit ddf23e3)
@BrewTestBot BrewTestBot mentioned this pull request May 19, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skartikey skartikey skartikey approved these changes

@mstrandboge mstrandboge mstrandboge approved these changes

Assignees

@mstrandboge mstrandboge

Labels
area/windows Related to windows plugins (win_eventlog, win_perf_counters, win_services) fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.34.4
Development

Successfully merging this pull request may close these issues.

win_eventlog buffer too small
3 participants
@srebhan @skartikey @mstrandboge