fix(inputs.cloudwatch): Handle metric includes/excludes correctly to prevent panic #16812
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstrandboge
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This change ensures safe handling when only one of StatisticInclude or StatisticExclude is non-nil, preventing a nil pointer dereference that was causing a panic.
Background
The bug stemmed from not accounting for all possible nil combinations of these two pointers. The existing if condition only handled the case where both were nil, but the else block did not properly handle scenarios where only one was set. This fix explicitly checks each pointer before dereferencing.
Checklist
Related issues
resolves #16779