Skip to content

chore(inputs.snmp_trap): Cleanup code #16810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 23, 2025
Merged

chore(inputs.snmp_trap): Cleanup code #16810

merged 1 commit into from
Apr 23, 2025

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Apr 16, 2025

Summary

This PR cleans the SNMP trap code in preparation of fixing #16222.

Checklist

  • No AI generated code was used in this PR

Related issues

related to #16222

@telegraf-tiger telegraf-tiger bot added chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Apr 16, 2025
@srebhan srebhan force-pushed the snmp_trap_cleanup branch from 5292f10 to 4f297d5 Compare April 16, 2025 12:34
@srebhan srebhan mentioned this pull request Apr 16, 2025
Merged
1 task
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

skartikey
skartikey reviewed Apr 16, 2025
View reviewed changes
@skartikey skartikey assigned mstrandboge and unassigned skartikey Apr 17, 2025
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 23, 2025
@mstrandboge mstrandboge merged commit 3895416 into influxdata:master Apr 23, 2025
27 checks passed
@github-actions github-actions bot added this to the v1.34.3 milestone Apr 23, 2025
srebhan added a commit that referenced this pull request May 5, 2025
@srebhan
chore(inputs.snmp_trap): Cleanup code (#16810)
600a01a 
(cherry picked from commit 3895416)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skartikey skartikey skartikey approved these changes

@mstrandboge mstrandboge mstrandboge approved these changes

+1 more reviewer

@Hipska Hipska Hipska approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@mstrandboge mstrandboge

Labels
chore plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.34.3
Development

Successfully merging this pull request may close these issues.
4 participants
@srebhan @Hipska @skartikey @mstrandboge