Skip to content

feat(inputs.whois): Support IDN domains #16700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 9, 2025
Merged

feat(inputs.whois): Support IDN domains #16700

merged 6 commits into from
Apr 9, 2025

Conversation

skartikey
Copy link
Contributor

@skartikey skartikey commented Mar 28, 2025 •
edited by srebhan
Loading

Summary

Add IDN Support to Whois Plugin

Enhances domain validation for Internationalized Domain Name (IDN) support by handling punycode conversion.

Implementation:

  • Validate as a standard ASCII domain first.
  • Convert non-ASCII domains to punycode with strict validation.
  • Ensure the converted domain matches ASCII or punycode patterns.

Checklist

  • No AI generated code was used in this PR

Related issues

related to: #16509

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 28, 2025
@skartikey
Copy link
Contributor Author

!signed-cla

srebhan
srebhan reviewed Mar 28, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @skartikey! A few small comments. It would also be good to add some test-cases for invalid ascii and punycode domains...

@srebhan srebhan changed the title feat(inputs.whois): add idn support to plugin feat(inputs.whois): Support IDN domains Mar 28, 2025
Hipska
Hipska reviewed Mar 28, 2025
View reviewed changes
@skartikey skartikey self-assigned this Mar 28, 2025
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@skartikey skartikey requested a review from srebhan March 31, 2025 09:56
@skartikey skartikey assigned srebhan and mstrandboge and unassigned skartikey Apr 2, 2025
srebhan
srebhan approved these changes Apr 9, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @skartikey!

@srebhan srebhan removed their assignment Apr 9, 2025
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 9, 2025
@mstrandboge mstrandboge merged commit df6d44e into influxdata:master Apr 9, 2025
27 checks passed
@github-actions github-actions bot added this to the v1.35.0 milestone Apr 9, 2025
skartikey added a commit to skartikey/telegraf that referenced this pull request Apr 14, 2025
@skartikey
feat(inputs.whois): Support IDN domains (influxdata#16700)
6083a22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulojmdias paulojmdias paulojmdias left review comments

@Hipska Hipska Hipska approved these changes

@srebhan srebhan srebhan approved these changes

@mstrandboge mstrandboge mstrandboge approved these changes

Assignees

@mstrandboge mstrandboge

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.35.0
Development

Successfully merging this pull request may close these issues.
5 participants
@skartikey @Hipska @srebhan @paulojmdias @mstrandboge