Skip to content

fix(agent): Condense plugin source information table when multiple plugins in same file #16638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2025
Merged

fix(agent): Condense plugin source information table when multiple plugins in same file #16638

merged 1 commit into from
Mar 21, 2025

Conversation

neelayu
Copy link
Contributor

@neelayu neelayu commented Mar 14, 2025

Summary

Keep one entry per file for multiple instances of plugins, ensuring the table is shorter and condensed. Also fix empty table printing when plugins(like processors, aggregators) are not loaded.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16637

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Mar 14, 2025
@neelayu neelayu changed the title feat(agent): Condense plugin source information table when multiple plugins in same file fix(agent): Condense plugin source information table when multiple plugins in same file Mar 14, 2025
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Mar 14, 2025
@neelayu
Copy link
Contributor Author

neelayu commented Mar 14, 2025

This should be labeled fix.

@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@neelayu
Copy link
Contributor Author

neelayu commented Mar 17, 2025

@llamafilm Can you check if the build from this PR fixes(or at least attempts to fix) your issue?

@srebhan srebhan added area/agent and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Mar 17, 2025
@llamafilm
Copy link
Contributor

LGTM, thanks!
image

srebhan
srebhan approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @neelayu!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 21, 2025
@mstrandboge mstrandboge merged commit 7556525 into influxdata:master Mar 21, 2025
29 checks passed
@github-actions github-actions bot added this to the v1.34.1 milestone Mar 21, 2025
justinwwhuang pushed a commit to justinwwhuang/telegraf_fork that referenced this pull request Mar 24, 2025
@neelayu @justinwwhuang
fix(agent): Condense plugin source information table when multiple pl…
827851f 
…ugins in same file (influxdata#16638)
justinwwhuang added a commit to justinwwhuang/telegraf_fork that referenced this pull request Mar 24, 2025
@justinwwhuang
parent 39c9a43
4796826 
author wenweihuang <hww_justin@163.com> 1740536737 +0800
committer wenweihuang <hww_justin@163.com> 1742792171 +0800

parent 39c9a43
author wenweihuang <hww_justin@163.com> 1740536737 +0800
committer wenweihuang <hww_justin@163.com> 1742791949 +0800

Reword comments and add error descriptions

chore(deps): Bump github.com/PaesslerAG/gval from 1.2.2 to 1.2.4 (influxdata#16612)

docs(aggregators): Document default settings for period, delay and grace (influxdata#16540)

chore(licenses): Fix link and whitelist package (influxdata#16622)

fix(outputs.influxdb_v2): Use dynamic token secret (influxdata#16628)

feat(inputs.unbound): Collect histogram statistics (influxdata#16452)

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Co-authored-by: Sven Rebhan <srebhan@influxdata.com>

chore: Run make docs

chore(deps): Bump github.com/aws/smithy-go from 1.22.2 to 1.22.3 (influxdata#16650)

chore(deps): Bump github.com/leodido/go-syslog/v4 from 4.1.0 to 4.2.0 (influxdata#16651)

chore(deps): Bump tj-actions/changed-files from v45 to v46.0.1 (influxdata#16659)

feat(outputs.stackdriver): Ensure quota is charged to configured project (influxdata#16583)

Co-authored-by: root <root@lpce28af8.homedepot.com>

chore(inputs.fritzbox): Fix linter issues (influxdata#16664)

fix(inputs.tail): Use correct initial_read_offset persistent offset naming in the code (influxdata#16643)

chore(deps): Bump golang.org/x/crypto from 0.35.0 to 0.36.0 (influxdata#16640)

fix(agent): Condense plugin source information table when multiple plugins in same file (influxdata#16638)

fix(outputs.sql): Allow to disable timestamp column (influxdata#16625)

test: Update fedora image for nightly test (influxdata#16675)

chore(deps): Bump k8s.io/api from 0.32.1 to 0.32.3 (influxdata#16653)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): Bump github.com/hashicorp/consul/api from 1.29.2 to 1.31.2 (influxdata#16652)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

feat(outputs.inlong) go mod tidy
justinwwhuang added a commit to justinwwhuang/telegraf_fork that referenced this pull request Mar 24, 2025
@justinwwhuang
parent 39c9a43
b1ccf75 
author wenweihuang <hww_justin@163.com> 1740536737 +0800
committer wenweihuang <hww_justin@163.com> 1742792171 +0800

parent 39c9a43
author wenweihuang <hww_justin@163.com> 1740536737 +0800
committer wenweihuang <hww_justin@163.com> 1742791949 +0800

Reword comments and add error descriptions

chore(deps): Bump github.com/PaesslerAG/gval from 1.2.2 to 1.2.4 (influxdata#16612)

docs(aggregators): Document default settings for period, delay and grace (influxdata#16540)

chore(licenses): Fix link and whitelist package (influxdata#16622)

fix(outputs.influxdb_v2): Use dynamic token secret (influxdata#16628)

feat(inputs.unbound): Collect histogram statistics (influxdata#16452)

Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Co-authored-by: Sven Rebhan <srebhan@influxdata.com>

chore: Run make docs

chore(deps): Bump github.com/aws/smithy-go from 1.22.2 to 1.22.3 (influxdata#16650)

chore(deps): Bump github.com/leodido/go-syslog/v4 from 4.1.0 to 4.2.0 (influxdata#16651)

chore(deps): Bump tj-actions/changed-files from v45 to v46.0.1 (influxdata#16659)

feat(outputs.stackdriver): Ensure quota is charged to configured project (influxdata#16583)

Co-authored-by: root <root@lpce28af8.homedepot.com>

chore(inputs.fritzbox): Fix linter issues (influxdata#16664)

fix(inputs.tail): Use correct initial_read_offset persistent offset naming in the code (influxdata#16643)

chore(deps): Bump golang.org/x/crypto from 0.35.0 to 0.36.0 (influxdata#16640)

fix(agent): Condense plugin source information table when multiple plugins in same file (influxdata#16638)

fix(outputs.sql): Allow to disable timestamp column (influxdata#16625)

test: Update fedora image for nightly test (influxdata#16675)

chore(deps): Bump k8s.io/api from 0.32.1 to 0.32.3 (influxdata#16653)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

chore(deps): Bump github.com/hashicorp/consul/api from 1.29.2 to 1.31.2 (influxdata#16652)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

feat(outputs.inlong) go mod tidy
srebhan pushed a commit that referenced this pull request Mar 24, 2025
@neelayu @srebhan
fix(agent): Condense plugin source information table when multiple pl…
84483cd 
…ugins in same file (#16638)

(cherry picked from commit 7556525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srebhan srebhan srebhan approved these changes

@mstrandboge mstrandboge mstrandboge approved these changes

Assignees

@mstrandboge mstrandboge

Labels
area/agent fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.34.1
Development

Successfully merging this pull request may close these issues.

Plugin source printer becomes too large if same plugin is used multiple times in a single file
5 participants
@neelayu @llamafilm @srebhan @mstrandboge @skartikey