-
Notifications
You must be signed in to change notification settings - Fork 5.7k
chore(deps): Bump github.com/gosmnp/gosnmp from 1.39.0 to 1.40.0 #16660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
63581ca
to
df047ef
Compare
84aab67
to
2ad914c
Compare
2ad914c
to
c131dd2
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 🥳 This pull request decreases the Telegraf binary size by -3.48 % for linux amd64 (new size: 285.4 MB, nightly size 295.7 MB) 📦 Click here to get additional PR build artifactsArtifact URLs |
// ordinary v3 coldstart trap SHA auth and no priv | ||
{ | ||
name: "coldStart authShaNoPriv", | ||
secName: "authShaNoPriv", | ||
secLevel: "authNoPriv", | ||
authProto: "SHA", | ||
authPass: "passpass", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this test removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this a duplicate of the test in line 422?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, that might indeed be the case.
) (cherry picked from commit db2c2d8)
Summary
Bump upstream library to fix authentication for v3 traps. Also add some unit-tests to prevent future regressions.
Checklist
Related issues
based on #16810
resolves #16222