Skip to content

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Mar 18, 2025

Summary

Bump upstream library to fix authentication for v3 traps. Also add some unit-tests to prevent future regressions.

Checklist

  • No AI generated code was used in this PR

Related issues

based on #16810
resolves #16222

@telegraf-tiger telegraf-tiger bot added the chore label Mar 18, 2025
@srebhan srebhan self-assigned this Mar 20, 2025
@srebhan srebhan force-pushed the snmp_trap_issue_16222 branch from 63581ca to df047ef Compare April 15, 2025 17:10
@srebhan srebhan changed the title chore(deps): Bump github.com/gosmnp/gosnmp chore(deps): Bump github.com/gosmnp/gosnmp from 1.39.0 to 1.40.0 Apr 16, 2025
@srebhan srebhan force-pushed the snmp_trap_issue_16222 branch from 84aab67 to 2ad914c Compare April 16, 2025 12:54
@srebhan srebhan added area/snmp dependencies Pull requests that update a dependency file labels Apr 23, 2025
@srebhan srebhan marked this pull request as ready for review April 23, 2025 13:14
@srebhan srebhan assigned skartikey and mstrandboge and unassigned srebhan Apr 23, 2025
@srebhan srebhan force-pushed the snmp_trap_issue_16222 branch from 2ad914c to c131dd2 Compare April 23, 2025 19:42
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -3.48 % for linux amd64 (new size: 285.4 MB, nightly size 295.7 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

Comment on lines -724 to -730
// ordinary v3 coldstart trap SHA auth and no priv
{
name: "coldStart authShaNoPriv",
secName: "authShaNoPriv",
secLevel: "authNoPriv",
authProto: "SHA",
authPass: "passpass",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this test removed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a duplicate of the test in line 422?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, that might indeed be the case.

@mstrandboge mstrandboge removed their assignment May 1, 2025
@mstrandboge mstrandboge added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 1, 2025
@skartikey skartikey merged commit db2c2d8 into influxdata:master May 1, 2025
27 checks passed
@github-actions github-actions bot added this to the v1.34.3 milestone May 1, 2025
srebhan added a commit that referenced this pull request May 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/snmp chore dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[inputs.snmp_trap] SNMP V3 trap input authentication settings being ignored
4 participants