Skip to content

fix(processors.execd): Detect line-protocol parser correctly #16535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 24, 2025
Merged

fix(processors.execd): Detect line-protocol parser correctly #16535

merged 3 commits into from
Feb 24, 2025

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Feb 20, 2025

Summary

This PR fixes the type assertion for detecting if we should use a streaming-parser or not by taking into account that a parser might be wrapped into a *models.RunningParser. Additionally, the PR adds a unit-test to check for long lines returned by the executable after cleaning up a bit.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15927

@telegraf-tiger telegraf-tiger bot added area/execd Issues related to execd or plugins that would be better suited to be used through execd fix pr to fix corresponding bug plugin/processor labels Feb 20, 2025
@srebhan srebhan mentioned this pull request Feb 20, 2025
Closed
@srebhan srebhan self-assigned this Feb 20, 2025
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

@srebhan srebhan changed the title fix(processors.execd): Detect line-protocol processor correctly fix(processors.execd): Detect line-protocol parser correctly Feb 20, 2025
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 24, 2025
@srebhan srebhan assigned mstrandboge and unassigned srebhan Feb 24, 2025
@mstrandboge mstrandboge merged commit af999bd into influxdata:master Feb 24, 2025
28 of 29 checks passed
@github-actions github-actions bot added this to the v1.33.3 milestone Feb 24, 2025
srebhan added a commit that referenced this pull request Feb 25, 2025
@srebhan
fix(processors.execd): Detect line-protocol parser correctly (#16535)
d34f912 
(cherry picked from commit af999bd)
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Mar 10, 2025
@srebhan @asaharn
fix(processors.execd): Detect line-protocol parser correctly (influxd…
a36e586 
…ata#16535)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mstrandboge mstrandboge mstrandboge approved these changes

Assignees

@mstrandboge mstrandboge

Labels
area/execd Issues related to execd or plugins that would be better suited to be used through execd fix pr to fix corresponding bug plugin/processor ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.33.3
Development

Successfully merging this pull request may close these issues.

type assertion in Execd processor when reading managed process's output fails, and large ILP lines fail to be tokenized
2 participants
@srebhan @mstrandboge