Skip to content

feat(processors.template): Add sprig function for templates #16497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 13, 2025
Merged

feat(processors.template): Add sprig function for templates #16497

merged 2 commits into from
Feb 13, 2025

Conversation

zan-xhipe
Copy link
Contributor

@zan-xhipe zan-xhipe commented Feb 10, 2025 •
edited
Loading

Summary

This enables the use of sprig functions in the template processor

Checklist

  • No AI generated code was used in this PR

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/processor labels Feb 10, 2025
srebhan
srebhan approved these changes Feb 10, 2025
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @zan-xhipe!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 10, 2025
Hipska
Hipska reviewed Feb 12, 2025
View reviewed changes
Copy link
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe just add a test to validate one (or more) of the sprig functions are actually available?

@zan-xhipe
Copy link
Contributor Author

@Hipska I have added a test case.

@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz

Hipska
Hipska approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@Hipska Hipska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, didn't even know you could also template the tag name 😄

@mstrandboge mstrandboge merged commit 9a43d7c into influxdata:master Feb 13, 2025
27 checks passed
@github-actions github-actions bot added this to the v1.34.0 milestone Feb 13, 2025
@zan-xhipe zan-xhipe deleted the procesors-template-sprig branch February 17, 2025 09:50
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Mar 10, 2025
@zan-xhipe @asaharn
feat(processors.template): Add sprig function for templates (influxda…
e385e11 
…ta#16497)

Co-authored-by: Pieter Slabbert <pieter.slabbert@ilovezoona.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hipska Hipska Hipska approved these changes

@srebhan srebhan srebhan approved these changes

@mstrandboge mstrandboge mstrandboge approved these changes

Assignees

@mstrandboge mstrandboge

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/processor ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
v1.34.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zan-xhipe @Hipska @srebhan @mstrandboge