fix(inputs.syslog): Fix for tests that started failing in 2025 #16364
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Hipska
approved these changes
Jan 7, 2025
1 task
|
@zak-pawel I think Dane already merged a fix in #16384. Could you confirm that his fix is working and close this PR? |
|
Dane did exactly the same thing in his PR as I did in mine, so I confirm that it works :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The RFC 3164 standard does not provide a year for the
TIMESTAMPfield (https://datatracker.ietf.org/doc/html/rfc3164#section-4.1.2), which is why the plugin, when parsing the timestamp, sets the current year.For both RFC 3164 tests, the timestamp is
Dec 2 16:31:03.In 2024, it parsed to
1733157063000000000.In 2025, it parsed to
1764693063000000000.In this PR, I'm updating the expected timeout to 2025. This is just a workaround that will stop working in 2026.
Checklist