feat(write): add no_sync option to the write command #26703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The influxdb3 write command was lacking a way to set the no_sync option which tells the server to acknowledge the write request before it is durable. This changeset provides a cli flag to configure that option and wire it into the client call. It adds a test that makes use of the new setter. It relies on other tests that the api works as it should. A few typos and a minor update the precision flag, to include the `auto` option, were also included. This will make using the write command for importing line protocol more flexible. * closes #26702
praveen-influx
approved these changes
Aug 20, 2025
| /// Give a quoted line protocol line via the command line | ||
| line_protocol: Option<Vec<String>>, | ||
|
|
||
| /// Specify a supported precision (eg: ns, us, ms, s). | ||
| /// Specify a supported precision (eg: auto, ns, us, ms, s). |
There was a problem hiding this comment.
I believe auto is left out as server sets it to Precision::Auto when it's not passed through, so users can leave out this argument when calling influxdb3 write.
influxdb/influxdb3_server/src/http.rs
Line 636 in 8dcb92c
I don't think there's any harm in exposing it, but setting explicitly to auto on client might be redundant.
There was a problem hiding this comment.
I think including it in the help is useful so users know it is an option; they might like to be explicit or future proof against changes to the default; but i don't feel strongly about it and its a minor thing. I'm inclined to leave it as in the pr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The influxdb3 write command was lacking a way to set the no_sync option which tells the server to acknowledge the write request before it is durable. This changeset provides a cli flag to configure that option and wire it into the client call. It adds a test that makes use of the new setter. It relies on other tests that the api works as it should.
A few typos and a minor update the precision flag, to include the
autooption, were also included.This will make using the write command for importing line protocol more flexible.
It can be exercised like so
influxdb3 write --no-sync --database foobar "m1 f=1"writecommand #26702