Skip to content

chore: updates to Dockerfile #26576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

chore: updates to Dockerfile #26576

merged 1 commit into from
Jul 1, 2025

Conversation

praveen-influx
Copy link
Contributor

  • update rust version to 1.88
  • remove defaulting to file for object store

@praveen-influx
chore: updates to Dockerfile
ee9e85e 
- update rust version to 1.88
- remove defaulting to `file` for object store

helps: influxdata/influxdb_pro#976
@praveen-influx praveen-influx force-pushed the chore/update-dockerfile branch from 93c0093 to ee9e85e Compare July 1, 2025 16:21
@praveen-influx praveen-influx requested a review from a team July 1, 2025 16:21
@pauldix
Copy link
Member

pauldix commented Jul 1, 2025

Do we want to change the Dockerfile object store default? Will this break our instructions for how to get going with Docker?

@praveen-influx
Copy link
Contributor Author

Do we want to change the Dockerfile object store default? Will this break our instructions for how to get going with Docker?

@pauldix - I thought we don't want to default to file and make users specify the object store. So, I just removed any defaults which includes Dockerfile. @jstirnaman will removing default to file break the instructions?

I had a quick look at our install script and it looks like it prints out command using memory as object store

influxdb/install_influxdb.sh

Lines 100 to 104 in 4694c83

if [ "${EDITION}" = "Core" ]; then
printf " └─ ${BOLD}docker run -it -p ${PORT}:${PORT} -v ./plugins:/plugins influxdb3-${EDITION_TAG} influxdb3 serve --object-store memory --node-id node0 --plugin-dir /plugins${NC} ${DIM}(To start)${NC}\n"
else
printf " └─ ${BOLD}docker run -it -p ${PORT}:${PORT} -v ./plugins:/plugins influxdb3-${EDITION_TAG} influxdb3 serve --object-store memory --node-id node0 --cluster-id cluster0 --plugin-dir /plugins${NC} ${DIM}(To start)${NC}\n"
fi

@pauldix
Copy link
Member

pauldix commented Jul 1, 2025

If people can set it and it's clear how to do so, then I think we're all good.

@praveen-influx
Copy link
Contributor Author

I'll merge this, @jstirnaman - please let me know if this is an issue.

@praveen-influx praveen-influx merged commit 1f02b3c into main Jul 1, 2025
15 checks passed
praveen-influx added a commit that referenced this pull request Jul 3, 2025
@praveen-influx @stuartcarnie
@mgattozzi @waynr @claude
chore: prep for 3.2.1 (branched from 3.2) (#26583)
7c4df6f 
* chore: version bump in Cargo.toml to 3.3.0-nightly (#26566)

* chore: version bump in Cargo.toml to 3.3.0-nightly

* chore: update install script to point to 3.2.0 version

* chore: Update to Rust 1.88 (#26567)

* chore: Update to Rust 1.88

* chore: Fixes missed by Claude

* fix: Add help text for the new update subcommand (#26569)

This adds the update command to the help text output which was an
oversight from my work in #26520.

* fix: --object-store is explicitly marked required (#26575)

Before this commit, although `--object-store` is mandatory it is not
reflected in the error messages. The examples are listed in the issue
976.

This commit makes `object_store` explicitly required which means error
messages include `--object-store` listed as mandatory

closes: influxdata/influxdb_pro#976

* chore: updates to Dockerfile (#26576)

- update rust version to 1.88
- remove defaulting to `file` for object store

helps: influxdata/influxdb_pro#976

* fix: v1 query API should default to ns for CSV output (#26577)

* fix: Existing soft-deleted schema can be hard-deleted (#26574)

* feat: Allow hard_deleted date of deleted schema to be updated

* feat: Include hard_deletion_date in `_internal` `databases` and `tables`

* feat: Unit tests for testing deleted databases

* chore: Default is now to hard-delete with default duration

* test: Update test names and assertions for new default hard deletion behavior

- Renamed delete_table_defaults_to_hard_delete_never to delete_table_defaults_to_hard_delete_default
- Renamed delete_database_defaults_to_hard_delete_never to delete_database_defaults_to_hard_delete_default
- Updated assertions to expect default deletion duration instead of None/Never
- Aligns with the change of HardDeletionTime default from Never to Default

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* chore: Remove TODO

* chore: PR feedback and other improvements

* Ensure system databases and tables schema specify a timezone for the
  `hard_deletion_time` Timestamp columns (otherwise they display without
  a timezone)
* `DELETE` using `default` delay is idempotent, so multiple requests
  will not continue to update the `hard_deletion_time`
* Improved test coverage for these behaviours

---------

Co-authored-by: Claude <noreply@anthropic.com>

---------

Co-authored-by: Stuart Carnie <stuart.carnie@gmail.com>
Co-authored-by: Michael Gattozzi <mgattozzi@influxdata.com>
Co-authored-by: wayne <wayne.warren.s@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pauldix pauldix pauldix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@praveen-influx @pauldix