Skip to content

Conversation

stuartcarnie
Copy link
Contributor

@stuartcarnie stuartcarnie commented Jun 26, 2025

🦀 1.88. See blog post for more!

Biggest change was the lint for uninlined format args

Copy link
Contributor

@waynr waynr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🦀

Copy link
Member

@pauldix pauldix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, have to retrain on how to do format and println!

@stuartcarnie stuartcarnie requested a review from waynr June 26, 2025 21:22
@stuartcarnie stuartcarnie merged commit d396921 into main Jun 26, 2025
12 checks passed
@stuartcarnie stuartcarnie deleted the sgc/rust_188 branch June 26, 2025 21:38
@mgattozzi
Copy link
Contributor

That’s a Rust 2021 feature. Doesn’t work if you need to make function calls but it’s always a more preferable experience for formatting

praveen-influx added a commit that referenced this pull request Jul 3, 2025
* chore: version bump in Cargo.toml to 3.3.0-nightly (#26566)

* chore: version bump in Cargo.toml to 3.3.0-nightly

* chore: update install script to point to 3.2.0 version

* chore: Update to Rust 1.88 (#26567)

* chore: Update to Rust 1.88

* chore: Fixes missed by Claude

* fix: Add help text for the new update subcommand (#26569)

This adds the update command to the help text output which was an
oversight from my work in #26520.

* fix: --object-store is explicitly marked required (#26575)

Before this commit, although `--object-store` is mandatory it is not
reflected in the error messages. The examples are listed in the issue
976.

This commit makes `object_store` explicitly required which means error
messages include `--object-store` listed as mandatory

closes: influxdata/influxdb_pro#976

* chore: updates to Dockerfile (#26576)

- update rust version to 1.88
- remove defaulting to `file` for object store

helps: influxdata/influxdb_pro#976

* fix: v1 query API should default to ns for CSV output (#26577)

* fix: Existing soft-deleted schema can be hard-deleted (#26574)

* feat: Allow hard_deleted date of deleted schema to be updated

* feat: Include hard_deletion_date in `_internal` `databases` and `tables`

* feat: Unit tests for testing deleted databases

* chore: Default is now to hard-delete with default duration

* test: Update test names and assertions for new default hard deletion behavior

- Renamed delete_table_defaults_to_hard_delete_never to delete_table_defaults_to_hard_delete_default
- Renamed delete_database_defaults_to_hard_delete_never to delete_database_defaults_to_hard_delete_default
- Updated assertions to expect default deletion duration instead of None/Never
- Aligns with the change of HardDeletionTime default from Never to Default

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* chore: Remove TODO

* chore: PR feedback and other improvements

* Ensure system databases and tables schema specify a timezone for the
  `hard_deletion_time` Timestamp columns (otherwise they display without
  a timezone)
* `DELETE` using `default` delay is idempotent, so multiple requests
  will not continue to update the `hard_deletion_time`
* Improved test coverage for these behaviours

---------

Co-authored-by: Claude <noreply@anthropic.com>

---------

Co-authored-by: Stuart Carnie <stuart.carnie@gmail.com>
Co-authored-by: Michael Gattozzi <mgattozzi@influxdata.com>
Co-authored-by: wayne <wayne.warren.s@gmail.com>
Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants