fix: prevent differing field types in the same shard (#26025) #26403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: lock MeasurementFields while validating (#25998) There was a window where a race between writes with differing types for the same field were being validated. Lock the MeasurementFields struct during field validation to avoid this. closes #23756 (cherry picked from commit 5a20a83) helps #26001 * fix: switch MeasurementFields from atomic.Value to sync.Map (#26022) Simplify and speed up synchronization for MeasurementFields structures by switching from a mutex and atomic.Value to a sync.Map (cherry picked from commit b617eb2) closes #26001 (cherry picked from commit 8711e2d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: switch MeasurementFields from atomic.Value to sync.Map (fix: switch MeasurementFields from atomic.Value to sync.Map #26022)
Simplify and speed up synchronization for
MeasurementFields structures by switching
from a mutex and atomic.Value to a sync.Map
(cherry picked from commit b617eb2)
closes Mismatched field type within shard causes panic [Port to main-2.x] #26001
fix: lock MeasurementFields while validating (fix: lock MeasurementFields while validating #25998)
There was a window where a race between writes with
differing types for the same field were being validated.
Lock the MeasurementFields struct during field
validation to avoid this.
closes Mismatched field type within shard causes panic #23756
(cherry picked from commit 5a20a83)
helps Mismatched field type within shard causes panic [Port to main-2.x] #26001