feat(array): Run-end encoded string arrays #5550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is very common for flux to be using arrays of strings containing a single repeated value. This is often the case when processing InfluxDB tag types. Ad support for run-end encoded string arrays to optimize for this case. Such arrays are quick to access as they consist of a single run, but use less memory than a full string array, or even a dictionary which still needs a full length array to hold the dictionary indexes.
appletreeisyellow
approved these changes
Aug 12, 2025
There was a problem hiding this comment.
Nice refactor! It would be helpful to link the run-end encoded layout doc somewhere in the comment for future references.
Comment on lines
+195
to
+196
| runEnds = array.NewInt32Data(data.Children()[0]) | ||
| values = array.NewBinaryData(data.Children()[1]) |
There was a problem hiding this comment.
The run-end encoded layout doc that you linked in the original issue was helpful in understanding the data structure here. Thank you for referencing!
| func (a *String) valuesIndex(i int) (int, bool) { | ||
| if a.indices != nil { | ||
| if a.indices.IsNull(i) { | ||
| return 0, false |
There was a problem hiding this comment.
👍
it’s null count field should always be 0. Null values are encoded as runs with the value null.
There was a problem hiding this comment.
You are looking at the dictionary encoding handling here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is very common for flux to be using arrays of strings containing a single repeated value. This is often the case when processing InfluxDB tag types. Ad support for run-end encoded string arrays to optimize for this case. Such arrays are quick to access as they consist of a single run, but use less memory than a full string array, or even a dictionary which still needs a full length array to hold the dictionary indexes.
Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
experimental/docs/Spec.mdhas been updatedDear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.