fix(stdlib): error if using limit with negative offset #5544
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A negative offset does not make sense with a limit function. Detect if a negative offset is being used and produce an error, rather than waiting for arrow to panic.
There was a problem hiding this comment.
Pull Request Overview
This PR adds an error check to the limit operation to ensure that a negative offset is not allowed and introduces new tests to verify the behavior.
- Added a negative offset test case to trigger an error.
- Implemented an error return in the limit operator for negative offset values.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| stdlib/universe/limit_test.go | Added tests to validate the limit function behavior with offsets. |
| stdlib/universe/limit.go | Updated the LimitOpSpec creation to error on negative offsets. |
crepererum
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A negative offset does not make sense with a limit function. Detect if a negative offset is being used and produce an error, rather than waiting for arrow to panic.
Fixes influxdata/influxdb#23265
Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
experimental/docs/Spec.mdhas been updatedDear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.