fix(libflux): fix libflux tests on aarch64-linux
#5542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
mhilton
approved these changes
Jun 11, 2025
|
The code change looks fine. Could you please run |
This test uses the `c_char` type and tried to negate it. This works on `x86_64` because `c_char` is signed, but this signedness is explicitly _implementation-defined_ in the standard. In fact, on `aarch64-linux`, `c_char` is unsigned, and in Rust unsigned values cannot be negated. To work around this, we must patch over this piece of ancient esoterica by telling the Rust compiler _exactly_ what we want to do. We specify that the literal is an `i8`, and then explicitly cast to `c_char`. Rust safely defines casts between signed and unsigned types to behave like two's complement, so `aarch64` systems will interpret it as `-61 + 256 = 195`. This does not appear to break the test :). Closes #5495
0cbc555 to
e21c235
Compare
|
thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a compilation error when testing on
aarch64-linuxplatforms. See commit and issue for details. Let's finish off this distro packaging annoyance for good 😆Closes #5495
Checklist
Dear Author 👋, the following checks should be completed (or explicitly dismissed) before merging.
experimental/docs/Spec.mdhas been updatedDear Reviewer(s) 👋, you are responsible (among others) for ensuring the completeness and quality of the above before approval.