Added support for the service monitor targetLabels #1805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanemerson
requested changes
Apr 17, 2023
pkg/reconcile/pipeline/infinispan/handler/provision/service_monitor.go
Outdated
Show resolved
Hide resolved
|
@ryanemerson updated the code as per the suggestion |
|
Thanks @andrey-dubnik. I'll release 2.3.2.CSV with this fix, it should be available tomorrow. |
|
@andrey-dubnik Docs PR: #1808 Unfortunately the release has had to be delayed, I'll let you know once it's available. |
|
@andrey-dubnik The 2.3.2 Operator has been released and merged into the Operator Hub repo, it should be available to consume. |
|
Thanks a lot @ryanemerson ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, hope opening PR is Ok? This should add support for the ServiceMonitor target labels as per #1804