Add Penumbra support to Features Matrix.
#3685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Penumbra (non-`cosmos-SDK`) support was added to the go-relayer in cosmos/relayer#1144 on March 31, 2023.
romac
suggested changes
Nov 7, 2023
| @@ -119,7 +119,8 @@ __Feature comparison between Hermes and the Go relayer__ | |||
| | Packet_Optimistic | ❌ | ❌ | relay packets over non-Open channels | |||
| | | | | | |||
| | Cl_Non_Tendermint | ❌ | ❌ | supports non tendermint IBC light clients | |||
| | Chain_Non_Cosmos | ❌ | ❌ | supports non cosmos-SDK chains | |||
| | Chain_Non_Cosmos | ❌ | ✅ | supports non cosmos-SDK chains | |||
| | Penumbra support | ❌ | ✅ | supports Penumbra non-cosmos-SDK chain | |||
There was a problem hiding this comment.
Suggested change
| | Penumbra support | ❌ | ✅ | supports Penumbra non-cosmos-SDK chain | |
| | Penumbra_Support | 🚧 | ✅ | Supports Penumbra non-Cosmos-SDK chain (Hermes support is a [work-in-progress](https://github.com/penumbra-zone/hermes/)) |
There was a problem hiding this comment.
I can't vouch for the content ("...Hermes support is a [work-in-progress]...") of these requested changes, and would n't be comfortable including them. Maybe submit them as a subsequent PR?
There was a problem hiding this comment.
Sure that's fine, we can merge as-is.
| @@ -119,7 +119,8 @@ __Feature comparison between Hermes and the Go relayer__ | |||
| | Packet_Optimistic | ❌ | ❌ | relay packets over non-Open channels | |||
| | | | | | |||
| | Cl_Non_Tendermint | ❌ | ❌ | supports non tendermint IBC light clients | |||
| | Chain_Non_Cosmos | ❌ | ❌ | supports non cosmos-SDK chains | |||
| | Chain_Non_Cosmos | ❌ | ✅ | supports non cosmos-SDK chains | |||
There was a problem hiding this comment.
Suggested change
| | Chain_Non_Cosmos | ❌ | ✅ | supports non cosmos-SDK chains | |
| | Chain_Non_Cosmos | 🚧 | ✅ | supports non Cosmos-SDK chains (better support for non-Cosmos-SDK chains is a work-in-progress, see the [Hermes SDK](https://github.com/informalsystems/hermes-sdk)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Penumbra (non-
cosmos-SDK) support was added to the go-relayer in cosmos/relayer#1144 on March 31, 2023.