[FIX] Unify Zq and Rq Balanced Base-b Decomposition Using Digit-Major Layout #979
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mposition_zq_digit_major
4964227 to
6210f89
Compare
| @@ -322,5 +206,4 @@ static eIcicleError cpu_recompose_from_balanced_digits_PolyRing( | |||
| return eIcicleError::SUCCESS; | |||
| } | |||
|
|
|||
| REGISTER_BALANCED_DECOMPOSITION_POLYRING_BACKEND( | |||
There was a problem hiding this comment.
Should REGISTER_BALANCED_DECOMPOSITION_POLYRING_BACKEND be removed from vec_ops_backend.h?
There was a problem hiding this comment.
Yes, good catch. I will fix
jeremyfelder
approved these changes
Jun 30, 2025
nonam3e
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the balanced base-b decomposition for Zq scalars to use a digit-major layout, consistent with the existing behavior for Rq polynomials. This enables unified and consolidated implementation across scalar and polynomial types.
Also testing case where input values are small and a user allocates a smaller output buffer for digits.
cuda-backend-branch: yshekel/balanced_decomposition_zq_digit_major_digit