[FEAT] Add reinterpretation utilities and polynomial vector operations #954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nonam3e
reviewed
Jun 19, 2025
| let from_size = size_of::<From>(); | ||
| let to_size = size_of::<To>(); | ||
|
|
||
| assert!(from_size > 0 && to_size > 0, "Invalid zero-sized types"); |
There was a problem hiding this comment.
maybe use Result here instead of assertion?
There was a problem hiding this comment.
It's a good point, I will make the reinterpret return a Result
nonam3e
reviewed
Jun 19, 2025
| } | ||
|
|
||
| fn memset(&mut self, _: u8, _: usize) -> Result<(), eIcicleError> { | ||
| panic!("Cannot memset immutable UnifiedSlice"); |
There was a problem hiding this comment.
Result here is returned, but panic is used inside
nonam3e
reviewed
Jun 19, 2025
Great observation. I refactored and return Results now so errors returned to used instead of panic |
nonam3e
approved these changes
Jun 19, 2025
LeonHibnik
approved these changes
Jun 22, 2025
LeonHibnik
pushed a commit
that referenced
this pull request
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reinterpret_sliceandreinterpret_slice_mutfor view castingHostOrDeviceSlicebetween any two typesflatten_polyring_sliceandflatten_polyring_slice_mutto abstract flattening ofHostOrDeviceSlice<P>toHostOrDeviceSlice<P::Base>polyvec_add,polyvec_sub,polyvec_mul,polyvec_mul_by_scalar, andpolyvec_sum_reduceoverHostOrDeviceSlice<PolynomialRing>cuda-backend-branch: main
metal-backend-branch: main