[FEAT] Add flattening utilities for polynomial slices into scalar slices #952
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| where | ||
| P: Clone, | ||
| { | ||
| pub fn check_vector_alloc<P: PolynomialRing>() { |
There was a problem hiding this comment.
I just removed the trait bound but actually it's a silly test. I will remove it
ChickenLover
approved these changes
Jun 18, 2025
LeonHibnik
approved these changes
Jun 18, 2025
There was a problem hiding this comment.
Nice, we should refactor the icicle-core/src/tests file in the future @yshekel
agreed |
LeonHibnik
pushed a commit
that referenced
this pull request
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some APIs operate on scalar elements rather than polynomials. To use them with polynomial data, we need to reinterpret polynomial slices as flat slices of their scalar coefficients.
This PR introduces four functions to safely flatten HostSlice and DeviceSlice—both mutable and immutable—into corresponding slices of scalar elements.
cuda-backend-branch: main
metal-backend-branch: main