Skip to content

[FEAT] Decompose Polynomial-rings #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jun 17, 2025
Merged

[FEAT] Decompose Polynomial-rings #945

merged 20 commits into from
Jun 17, 2025

Conversation

yshekel
Copy link
Collaborator

@yshekel yshekel commented Jun 15, 2025 •
edited
Loading

  • Fix the decomposition rust API to execute on rings, not only prime-fields
  • Implement the decomposition for polynomial rings instead of integer-rings (can do both in v4 but currently they do not match in design due to the the Config type that is removed in v4)
  • update decomposition layout to be digit-major

cuda-backend-branch: yshekel/decompose_digit_major_layout
metal-backend-branch: main

yshekel added 19 commits June 12, 2025 15:42
@yshekel
[FEAT] PolynomialRing trait with instantiation macro and tests
2c9a093
@yshekel
minor
e359025
@yshekel
Negacyclic ntt
6b87439
@yshekel
minor
ea92115
@yshekel
Randomize polyRing elements
fbb6e3b
@yshekel
minor
b465e3e
@yshekel
check inputs
30df911
@yshekel
removed Generate trait and implement GenerateRandom instead
10cd774
@yshekel
make negacyclic ntt test phase-2
8d7e3a3
@yshekel
updated test
6493caf
@yshekel
docs and floating ntt apis
a1ebf5a
@yshekel
link to icicle-hash
baadba1
@yshekel
Merge remote-tracking branch 'origin/main' into yshekel/labradror_rus…
06d422f 
…t_rq
@yshekel
Balanced-decomposition for general rings
b16b4ca
@yshekel
polyring implements common traits
ed9dfa7
@yshekel
Merge remote-tracking branch 'origin/yshekel/labradror_rust_rq' into …
79b307a 
…yshekel/rust_decompose
@yshekel
update decomposition test to match digit-major layout
2db85c7
@yshekel
code review
a754ecd
@yshekel
Merge remote-tracking branch 'origin/yshekel/labradror_rust_rq' into …
1873fb2 
…yshekel/rust_decompose
@yshekel yshekel changed the title Decompose Polynomial-rings [FEAT] Decompose Polynomial-rings Jun 15, 2025
@yshekel yshekel changed the base branch from yshekel/labradror_rust_rq to main June 15, 2025 15:43
@yshekel yshekel changed the base branch from main to yshekel/labradror_rust_rq June 15, 2025 15:49
@yshekel yshekel changed the base branch from yshekel/labradror_rust_rq to main June 15, 2025 16:22
LeonHibnik
LeonHibnik approved these changes Jun 16, 2025
View reviewed changes
Copy link
Contributor

@LeonHibnik LeonHibnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@yshekel yshekel merged commit e7f202e into main Jun 17, 2025
41 of 61 checks passed
LeonHibnik pushed a commit that referenced this pull request Jun 30, 2025
@yshekel @LeonHibnik
[FEAT] Rust wrapper for polynomial-rings decomposition (#945)
b38db8b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChickenLover ChickenLover ChickenLover approved these changes

@LeonHibnik LeonHibnik LeonHibnik approved these changes

@jeremyfelder jeremyfelder Awaiting requested review from jeremyfelder

@dorshmil dorshmil Awaiting requested review from dorshmil

@emirsoyturk emirsoyturk Awaiting requested review from emirsoyturk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yshekel @ChickenLover @LeonHibnik