[FEAT] Rust memset #849
Merged
[FEAT] Rust memset #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yshekel
reviewed
Apr 8, 2025
| return Ok(()); | ||
| } | ||
| if !self.is_on_active_device() { | ||
| panic!("not allocated on an inactive device"); |
yshekel
reviewed
Apr 8, 2025
yshekel
reviewed
Apr 8, 2025
| @@ -241,6 +241,30 @@ impl<T> DeviceSlice<T> { | |||
| .wrap() | |||
| } | |||
| } | |||
|
|
|||
| pub fn memset(&mut self, value: u8) -> Result<(), eIcicleError> { | |||
There was a problem hiding this comment.
Why doesn't it take size too? Does it set the entire slice?
yshekel
reviewed
Apr 8, 2025
| &mut self[..] | ||
| } | ||
|
|
||
| pub fn memset(&mut self, value: u8) -> Result<(), eIcicleError> { |
There was a problem hiding this comment.
Given we can memset a deviceSlice why do we need it also for DeviceVec?
And here also it's memset the entire vector but usually we want to to memset offset+:size.
Can we implement it on HostOrDeviceSlice instead? If yes then we can memset any memory with offest+size, regardless being host/device memory. We probably also would need to sub-slice HostOrDeviceSlice to be fully flexible.
There was a problem hiding this comment.
Moved impl to HostOrDeviceSlice
nonam3e
approved these changes
Apr 9, 2025
yshekel
reviewed
Apr 10, 2025
| @@ -81,6 +84,32 @@ impl<T> HostOrDeviceSlice<T> for HostSlice<T> { | |||
| fn is_empty(&self) -> bool { | |||
| self.len() == 0 | |||
| } | |||
|
|
|||
| fn memset(&mut self, value: u8, size: usize) -> Result<(), eIcicleError> { | |||
| if size == 0 || self.is_empty() { | |||
There was a problem hiding this comment.
This is a strange case, why not panic? should be super rare but why would someone do it?
yshekel
approved these changes
Apr 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes
This PR adds support for using icicle_memset in icicle rust wrapper
Linked Issues
Resolves #
(optional) CUDA backend branch
cuda-backend-branch: main # specify the branch here