Implement Goldilocks on top of icicle-math for backend-specific optimizations #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the tests fail, no poseidon support yet
|
Why isn't it part of #837 ? |
yshekel
approved these changes
Apr 7, 2025
LeonHibnik
approved these changes
Apr 7, 2025
jeremyfelder
approved these changes
Apr 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the implementation of the goldilocks addition and reduction into separate implementations for CPU and CUDA and optimizes the CUDA implementation.
CUDA backend branch
cuda-backend-branch: goldilocks
the relevant backend PR is https://github.com/ingonyama-zk/icicle-cuda-backend/pull/65