Skip to content

Make Go bindings work with Metal backend #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 10, 2025
Merged

Make Go bindings work with Metal backend #825

merged 5 commits into from
Apr 10, 2025

Conversation

jeremyfelder
Copy link
Collaborator

Describe the changes

This PR

  • Updates the Go bindings README to explain what environment variables are needed in order to use it
  • Removes the default installation location of /usr/local/lib for Go as this has caused issues
  • Fixes formatting issues in Go frontend files
  • Updates Go tests to work with any MAIN device
  • Fixes cgo types issue in hash and merkle functions
  • Fixes suppression of Taskflow messages in CPU backend cmake file
  • Converted bash script for building libs to be a Go script

@LeonHibnik LeonHibnik mentioned this pull request Mar 31, 2025
Merged
LeonHibnik
LeonHibnik reviewed Apr 1, 2025
View reviewed changes
Copy link
Contributor

@LeonHibnik LeonHibnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 💪
Left some comments

@jeremyfelder jeremyfelder requested a review from LeonHibnik April 1, 2025 16:15
@LeonHibnik LeonHibnik merged commit 6908c9f into main Apr 10, 2025
18 checks passed
@LeonHibnik LeonHibnik deleted the fix/golang/metal branch April 10, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nonam3e nonam3e nonam3e approved these changes

@LeonHibnik LeonHibnik LeonHibnik approved these changes

@emirsoyturk emirsoyturk Awaiting requested review from emirsoyturk

@yshekel yshekel Awaiting requested review from yshekel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeremyfelder @nonam3e @LeonHibnik