Skip to content

Conversation

mickeyasa
Copy link
Contributor

add the classes for sumcheck frontend

@mickeyasa mickeyasa requested a review from yshekel December 23, 2024 06:31
Copy link
Collaborator

@yshekel yshekel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good but I left some comments

* @return Error code of type eIcicleError indicating success or failure.
*/
eIcicleError verify(
SumcheckProof<F>& sumcheck_proof,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not const proof?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mickeyasa mickeyasa merged commit 6d69613 into main Jan 20, 2025
15 checks passed
@mickeyasa mickeyasa deleted the add-sumcheck-frontend branch January 20, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants