-
Notifications
You must be signed in to change notification settings - Fork 155
add sumcheck frontend #692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good but I left some comments
- Update Cmake for android cross compilation - Update log.h for android logcat
icicle-babybear@3.4.0 icicle-bls12-377@3.4.0 icicle-bls12-381@3.4.0 icicle-bn254@3.4.0 icicle-bw6-761@3.4.0 icicle-core@3.4.0 icicle-grumpkin@3.4.0 icicle-hash@3.4.0 icicle-koalabear@3.4.0 icicle-m31@3.4.0 icicle-runtime@3.4.0 icicle-stark252@3.4.0 Generated by cargo-workspaces
delete poseidon2 sidebar
Co-authored-by: Leon Hibnik <leon@ingonyama.com>
* @return Error code of type eIcicleError indicating success or failure. | ||
*/ | ||
eIcicleError verify( | ||
SumcheckProof<F>& sumcheck_proof, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not const proof?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the classes for sumcheck frontend