Skip to content

fix(build): use .module.js instead of .mjs for esm bundle, closes #331 #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 13, 2019
Merged

fix(build): use .module.js instead of .mjs for esm bundle, closes #331 #332

merged 1 commit into from
Mar 13, 2019

Conversation

egoist
Copy link
Contributor

@egoist egoist commented Mar 13, 2019 •
edited
Loading

closes #331

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.739% when pulling 9d790cd on egoist-bot:fix/mjs into 0e5ecc9 on mweststrate:master.

@mweststrate
Copy link
Collaborator

Could you give some background why the extension difference matters?

@egoist
Copy link
Contributor Author

egoist commented Mar 13, 2019

@mweststrate metro bundler doesn't support .mjs yet, it will try to resolve immer/dist/immer.mjs(.native||.ios.js|.native.js|.js|.ios.json|.native.json|.json|.ios.ts|.native.ts|.ts|.ios.tsx|.native.tsx|.tsx)

@aleclarson aleclarson merged commit 8b33b98 into immerjs:master Mar 13, 2019
@aleclarson
Copy link
Collaborator

Thanks @egoist! ❤️

@aleclarson
Copy link
Collaborator

🎉 This PR is included in version 2.1.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@cdauth cdauth mentioned this pull request Jan 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

react native can not recognize .mjs file
4 participants
@egoist @coveralls @mweststrate @aleclarson