Skip to content

Conversation

MUHAMMADMUKHTARSULEIMAN
Copy link
Contributor

It read "So an url," so I merely changed the an to a.

It read "So an url," so I merely changed the an to a.
@mweststrate
Copy link
Collaborator

I'm not a native speaker either, but afaik "an URL" is grammatically correct since the acronym starts with a vowel.

@mweststrate mweststrate closed this Mar 9, 2024
@mweststrate mweststrate reopened this Mar 9, 2024
@mweststrate
Copy link
Collaborator

Quick google says you're right though since the "U" is pronounced as a consonant. :) Ugh, English. Merging.

@mweststrate mweststrate merged commit a73ebf3 into immerjs:main Mar 9, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8217380875

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.793%

Totals Coverage Status
Change from base Build 8217372082: 0.0%
Covered Lines: 647
Relevant Lines: 648

💛 - Coveralls

Copy link
Contributor

🎉 This PR is included in version 10.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants