🙋‍♂ Question

Here is two question, when will a plain object contain drafts in the recursively finalize function?

I think a plain object here always means not modify in produce() and not create by immer proxy, maybe move a proxy draft property into new object then add it back to draft's new property field?

Is that the only thing need to do in this condition for plain object is maybeFreeze(rootScope, value, true) rather than each(finalizeProperty(...))) ?

I think this is the reason to cause some UNEXPECTED access to getter property in an irrelevant plain object when produce() returns result, which will have some side effects.

The problem case like below:

Link to repro

To reproduce: https://stackblitz.com/edit/node-pgmcfz?file=immer-getter-without-freeze.mjs

Environment

• Immer version: 9.0.17
• Occurs with setUseProxies(true)
• Occurs with setUseProxies(false) (ES5 only)