Skip to content

Conversation

j-bowhay
Copy link

I think we should probably update docstring to reflect the changes that have happened under the hood. Feel free to rephrase as you see fit

ilayn and others added 30 commits December 30, 2023 18:35
* MAINT: special: remove goto in acai

* MAINT: special: remove some gotos from bknu

* MAINT: simplify if statements

* MAINT: special: remove a few gotos unk1

* MAINT: remove duplicate code in acai

* STY:special:amos:Basic fixups for do loops

---------

Co-authored-by: Ilhan Polat <ilhanpolat@gmail.com>
j-bowhay and others added 4 commits January 12, 2024 11:13
* MAINT: special: remove goto in acai

* MAINT: special: remove some gotos from bknu

* MAINT: simplify if statements

* MAINT: special: remove a few gotos unk1

* MAINT: remove duplicate code in acai

* STY:special:amos:Basic fixups for do loops

---------

Co-authored-by: Ilhan Polat <ilhanpolat@gmail.com>
MAINT:special:amos: Add const specifier for array data

STY:special:amos: Cleanup and organize data and comments

MAINT:special:amos: Silence compiler for fabs(integer) use
@ilayn
Copy link
Owner

ilayn commented Jan 13, 2024

Oh indeed, I completely forgot all this 😄, thanks.

It seems to me that we don't need to bother folks with the translation detail or in fact all that z letters which is the type of the argument, a typical Fortranism for float, double and complex variants s, d, c, z. What do you think ?

By the way, it seems like you are not on the latest state of the branch, I still see Cython etc. commits

@j-bowhay
Copy link
Author

Oh indeed, I completely forgot all this 😄, thanks.

No worries I think it might also be worth updating the docstring for functions that use cfdlib too. Happy to open a PR on main.

It seems to me that we don't need to bother folks with the translation detail or in fact all that z letters which is the type of the argument, a typical Fortranism for float, double and complex variants s, d, c, z. What do you think ?

Happy to slim down the description but think it is worth keeping the type letter as cairy and zairy have slightly different implementations, for example, so it might be useful for the sake of one letter to have all the information. How about Wrapper for a translation of the AMOS [1]_ routines `zairy` and `zbiry`. for example?

By the way, it seems like you are not on the latest state of the branch, I still see Cython etc. commits

Yes realised I should have rebased rather than merged.

@ilayn
Copy link
Owner

ilayn commented Jan 13, 2024

How about Wrapper for a translation of the AMOS [1]_ routines zairy and zbiry. for example?

I'm a bit leaning towards uses ``zairy``, ``zbiry`` from AMOS [1]_. Because probably nobody cares what or how we used the functions. But don't have any strong opinions really. I'd surprised if people even know what AMOS is anymore :) So pick which one sounds right for you.

I think it might also be worth updating the docstring for functions that use cfdlib too. Happy to open a PR on main

Indeed.

@ilayn
Copy link
Owner

ilayn commented Jan 14, 2024

Albert pushed the button a bit too early before we can react 😂 So i think you can freely open proper PRs now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants