-
Notifications
You must be signed in to change notification settings - Fork 1
DOC: special: update docstrings to reflect C translation of AMOS #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[skip ci]
[skip ci]
[skip ci]
Also removed one extra GO TO
* MAINT: special: remove goto in acai * MAINT: special: remove some gotos from bknu * MAINT: simplify if statements * MAINT: special: remove a few gotos unk1 * MAINT: remove duplicate code in acai * STY:special:amos:Basic fixups for do loops --------- Co-authored-by: Ilhan Polat <ilhanpolat@gmail.com>
* MAINT: special: remove goto in acai * MAINT: special: remove some gotos from bknu * MAINT: simplify if statements * MAINT: special: remove a few gotos unk1 * MAINT: remove duplicate code in acai * STY:special:amos:Basic fixups for do loops --------- Co-authored-by: Ilhan Polat <ilhanpolat@gmail.com>
MAINT:special:amos: Add const specifier for array data STY:special:amos: Cleanup and organize data and comments MAINT:special:amos: Silence compiler for fabs(integer) use
a6e2541
to
d604107
Compare
d604107
to
6b7d0e2
Compare
Oh indeed, I completely forgot all this 😄, thanks. It seems to me that we don't need to bother folks with the translation detail or in fact all that z letters which is the type of the argument, a typical Fortranism for float, double and complex variants By the way, it seems like you are not on the latest state of the branch, I still see Cython etc. commits |
No worries I think it might also be worth updating the docstring for functions that use cfdlib too. Happy to open a PR on main.
Happy to slim down the description but think it is worth keeping the type letter as
Yes realised I should have rebased rather than merged. |
I'm a bit leaning towards
Indeed. |
Albert pushed the button a bit too early before we can react 😂 So i think you can freely open proper PRs now |
I think we should probably update docstring to reflect the changes that have happened under the hood. Feel free to rephrase as you see fit