Add symbols in Katakana block #190
Conversation
src/index.ts
Outdated
| @@ -23,6 +23,7 @@ const cjkPunctuations = unicode({ | |||
| 'Kanbun', | |||
| 'CJK_Strokes', | |||
| 'Enclosed_CJK_Letters_And_Months', | |||
| 'Katakana', | |||
There was a problem hiding this comment.
Hello @tats-u, I just got access to this repo, I'll take care of this PR.
There seems more than just U+30FB and U+30A0, are you sure there should all treat as punctuations?
There was a problem hiding this comment.
As you may suspect, many of them are just letters. I have to modify the code.
There was a problem hiding this comment.
@fisker I remembered I've thought all of the non-punctuation characters in the Katakana block are included in cjkLetters because of .subtract(cjkLetters). I don't think I have to remove this line. I don't think I have to remove this line now.
There was a problem hiding this comment.
All right, I'll take a look tomorrow.
# Conflicts: # tests/__snapshots__/index.test.ts.snap
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
I checked the new diff too. LGTM. Thank you for the merging. |
|
I'll improve the snapshot a little bit, and release a new version. |
|
Released v3.3.0, would you like to upgrade it in Prettier? |
Fixes #189
Also, han with Ideographic Variation Sequence (U+E0100–U+E01EF) is now treated as CJK.E.g. 竈門禰󠄀(U+79B0 U+E0100)豆子