Fix audio stutter, dropped frames entering full-screen, #5352 #5355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will: - Remove the suspend and resume methods from ViewLayer - Remove the blocked property from ViewLayer - Remove the reference to the blocked property in MPVController.mpvUpdateCallback - Remove the calls to suspend in the windowWillEnterFullScreen and windowWillExitFullScreen methods in MainWindowController - Remove the calls to resume in windowDidEnterFullScreen and windowDidExitFullScreen in MainWindowController Possibly suspending video processing was useful in the past with low performance hardware, but it is consistently triggering audio device underrun and sometimes triggering full audio/video desynchronization. The mpv player does not suspend video processing like this and does not exhibit problems entering and leaving full screen mode. Removing this code significantly improved the behavior of entering and leaving full screen mode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
suspendandresumemethods fromViewLayerblockedproperty fromViewLayerblockedproperty inMPVController.mpvUpdateCallbacksuspendin thewindowWillEnterFullScreenandwindowWillExitFullScreenmethods inMainWindowControllerresumein thewindowDidEnterFullScreenandwindowDidExitFullScreenmethods inMainWindowControllerPossibly suspending video processing was useful in the past with low performance hardware, but it is consistently triggering audio device underrun and sometimes triggering full audio/video desynchronization. The mpv player does not suspend video processing like this and does not exhibit problems entering and leaving full screen mode. Removing this code significantly improved the behavior of entering and leaving full screen mode.
Description: