Add a loading window when loading network resources #5152
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- close the current window when loading a network resource
- Enabled auto save for the open URL window
|
Looks nice! Definitely a good idea. One request: could there be a "Stop" or "Cancel" button once it starts to load? In case it gets stuck on a bad connection, that would give an impatient user a way out. Would be ideal if it could just show the form again without clearing any of the fields which were filled out. |
Will add this in a follow up PR. |
svobs
pushed a commit
to svobs/iina-advance
that referenced
this pull request
Oct 14, 2024
* Show loading window when the resource is network * Close the window when mainWindow is open - close the current window when loading a network resource * Add "Loading Media……" into en.lproj * Handle error in the OpenURLWindow when network resource is failed to load * Optimize layout * Refactor error handling to make sure always close current window - Enabled auto save for the open URL window * Save the loading URL when loading file
MouJieQin
pushed a commit
to MouJieQin/iina-for-varchive
that referenced
this pull request
Oct 21, 2024
* Show loading window when the resource is network * Close the window when mainWindow is open - close the current window when loading a network resource * Add "Loading Media……" into en.lproj * Handle error in the OpenURLWindow when network resource is failed to load * Optimize layout * Refactor error handling to make sure always close current window - Enabled auto save for the open URL window * Save the loading URL when loading file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
After #5054, the main window will show after the video is loaded by mpv and the video size is available from mpv. Therefore when the user is loading a video from Internet through yt-dlp, nothing will show up until the video is loaded, which will take a considerate amount of time. This PR adds a loading window (which reuses the
OpenURLWindow) when opening a URL.Changes in this PR:
OpenURLWindowwhich works as a loading screen for when loading internet resourcesOpenURLWindowOpenURLWindowwhen loading a URL, stop the player coreinfo.state == .loadingtoinfo.state == .startingwhen deciding whether or not mpv couldn't load the URLOpenURLWindowis open with the loading screen,OpenURLWindowwill change back to normal mode with error message, so that the user can input another URL and try again. See the video below:Error.handling.-.old.mov
Error.handling.-.new.mov