Skip to content

Add a setting to let user to choose coreaudio or avfoundation as the audio driver #5137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 15, 2024

Conversation

uiryuu
Copy link
Member

@uiryuu uiryuu commented Aug 14, 2024


Description:
Added descriptive text to indicate AVFoundation is an experimental audio driver which may cause issues.

image

Copy link
Contributor

@low-batt low-batt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good. With the suggested code change the audio driver can be dynamically changed. There is a couple of seconds delay and then mpv starts the audio again using the selected driver. This might be useful to users who like Spatial Audio, but don't like the mute delay bug with AVFoundation. So they might switch to AVFoundation only when playing a video with Spatial Audio. I'm thinking make this dynamic, just because I think apps should always avoid the requirement to restart after changing a setting, if possible. If we do make it dynamic we should update the Inspector window to understand the driver can change. Thoughts?

@low-batt
Copy link
Contributor

Noticed one other thing. The help button is way over to the right edge whereas other help buttons are close to the setting.

@uiryuu
Copy link
Member Author

uiryuu commented Aug 15, 2024

The help button is way over to the right edge whereas other help buttons are close to the setting.

I intentionally did this, because I also added a "flask" icon to indicate AVFoundation is an experimental option. I moved the question mark away to separate those 2 icons.

@low-batt low-batt merged commit cc75a34 into develop Aug 15, 2024
1 check passed
@uiryuu uiryuu deleted the audio-driver branch August 15, 2024 11:49
svobs pushed a commit to svobs/iina-advance that referenced this pull request Oct 12, 2024
…audio driver (iina#5137)

Add a setting to let user to choose coreaudio or avfoundation as ao

Ref: 5064

Co-authored-by: low-batt <86170219+low-batt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants