Update Settings' tab icons & toolbar icons using SF symbols #5125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a009aa to
e7b6250
Compare
- Added a function to automatically detect the availablity of SF symbols and return fallback image if its not available
|
Two quick thoughts… Issue #3158 has this response from @lhc70000 regarding use of SF Symbols for the OSC:
Does this problem with small SF Symbols still exist? Instead of a function in |
|
I'm actually using a 100% screen, and I don't see a readability issue here. |
3e4da9e to
d063f1d
Compare
low-batt
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Now that the plugin system has been enabled by default (f784974), we need a new icon for that. To take advantage of this opportunity, I chose some icons from SF symbols to replace the current ones, which are really old btw. Icons are not available at runtime are simply fallback to the old ones.
before -> after
I also updated the icons for toolbar items:
The paddings in this one needs to be adjusted later.
Feel free to propose better ones