Add scale to the ASS subtitles override level slider #5050
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will: - Add a new scale enum constant to SubOverrideLevel in Preferences - Add translations for scale in base and English Localizable.strings - Lengthen the override level slider and add an additional tick mark for scale - Add a ASSOverrideLevelValueTransformer class to PrefSubViewController - Change the override level slider to use the transformer when accessing the subOverrideLevel setting This adds the missing scale value from IINA's Override level setting found in the ASS Subtitles section on the Subtitle tab of IINA's settings. To preserve backward compatibility with enum values stored in user's settings scale was added to the end of the enumeration. This means the enum raw values do not reflect the correct order needed for the slider. The transformer adjusts the values to provide a proper ordering for the slider.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
SubOverrideLevelinPreferencesLocalizable.stringsASSOverrideLevelValueTransformerclass toPrefSubViewControllersubOverrideLevelsettingThis adds the missing
scalevalue from IINA'sOverride levelsetting found in theASS Subtitlessection on theSubtitle tabof IINA's settings. To preserve backward compatibility with enum values stored in user's settingsscalewas added to the end of the enumeration. This means the enum raw values do not reflect the correct order needed for the slider. The transformer adjusts the values to provide a proper ordering for the slider.Description: