Fix UI elements not synced when changing modes, #4985 #5039
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed `SyncUIOption.muteButton`, use `.volume` instead - Added a helper function to sync multiple UI options - Added a function to setup all UI elements, called when switching - Added `currentController`; when syncing UI, only update the UI in the current window - Call `updateAdditionalInfo` when entering full screen
|
I think I also accidentally fixed #4985 in this PR |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This commit fixes 2 bugs when changing modes at paused state:
This commit also added
currentControllerwhich auto select the current window controller (mainWindow/miniPlayer). When syncing UI, only the controls in the current window is updated.