Update highlight of sidebar tab buttons so they all match (fixes issue #4332) #4378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the styling of Quick Settings tabs
|
Update: found a case which I missed, where the Playlist was displayed in Music Mode right after starting IINA. Fixed in the latest commit. |
|
For me the Playlist and Chapters tabs do not match. Looks like the Playlist font is bold and Chapters isn't? |
Good catch. Made another commit to address this. |
low-batt
approved these changes
Apr 23, 2023
uiryuu
requested changes
Apr 29, 2023
iina/ExtendedColors.swift
Outdated
| @@ -36,3 +36,9 @@ extension NSColor.Name { | |||
| static let sidebarTabTint = NSColor.Name("SidebarTabTint") | |||
| static let sidebarTabTintActive = NSColor.Name("SidebarTabTintActive") | |||
| } | |||
|
|
|||
| @available(OSX 10.14, *) | |||
There was a problem hiding this comment.
Suggested change
| @available(OSX 10.14, *) | |
| @available(macOS 10.14, *) |
There was a problem hiding this comment.
Updated in latest commit
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Analysis: For newer versions of MacOS (10.14+), the 3 Quick Settings tab buttons are displayed all in bold, and the active tab's button text tint is set to pure black. However, the Playlist & Chapters tabs were following (what looks like) an older scheme: the active tab was bold, and the other tab was not bold; neither had a special tint. (The Quick Settings tabs fall back to this behavior for older versions of MacOS).
This update changes Playlist & Chapters so that they match the behavior of the other three