-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Added option to always show OSC, #4366 #4372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@smishralm10 Thanks for looking into this. This should be simplified. This should not be about adding a new setting to keep the OSC always visible. This should be about making the existing setting to hide the OSC optional. Instead of adding |
Thanks for feedback. I'll implement the required changes |
Pulled and ran this PR. Wanted to note a couple of wrinkles. Biggest concern: I noticed this also disables the "hide when cursor exits the window" functionality. I've been meaning to post a PR at some point which breaks that out into its own checkbox. Doesn't think seem like a separate piece of functionality? More of a side note: this PR also means that the title bar also won't go away, even though it's covering the video. I realize this is hard to avoid from a functional standpoint, because the title bar & OSC are currently so coupled. At least there's still one way to hide them both, which is to go to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled the PR locally, built IINA and confirmed the new setting worked.
@smishralm10 Thanks for making the changes! @svobs I tried this:
But could not get the OSC to hide. More work is needed in this area. There are outstanding requests for other OSC options. One is to add a |
Thanks! |
Description:
This commit adds the requested feature #4366. Changes: