Skip to content

Added option to always show OSC, #4366 #4372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2024
Merged

Conversation

smishralm10
Copy link
Contributor

@smishralm10 smishralm10 commented Apr 21, 2023


Description:
This commit adds the requested feature #4366. Changes:

  • Option added to always show OSC in Settings > UI > On Screen Controller > Always show OSC (disabled by default)
    Screenshot 2023-04-21 at 1 58 36 PM
  • when this option is enabled "Auto hide after" textfield will be disabled (shown in the image below)
    Screenshot 2023-04-21 at 1 58 50 PM

@low-batt
Copy link
Contributor

@smishralm10 Thanks for looking into this.

This should be simplified. This should not be about adding a new setting to keep the OSC always visible. This should be about making the existing setting to hide the OSC optional. Instead of adding Always show OSC, a checkbox should be added to the existing Auto hide after setting. When that is unchecked the TextField for entering the number of seconds should be disabled. The preference becomes enableControlBarAutoHide.

@low-batt low-batt linked an issue Apr 21, 2023 that may be closed by this pull request
@smishralm10
Copy link
Contributor Author

Thanks for feedback. I'll implement the required changes

@smishralm10
Copy link
Contributor Author

This commit adds a checkbox to the existing Auto hide after option and removes Always show OSC option. Disabling Auto hide after option will disable the TextField beside it, as shown in the below images.

Screenshot 2023-04-22 at 12 10 37 AM

Screenshot 2023-04-22 at 12 10 46 AM

@svobs
Copy link
Contributor

svobs commented Apr 21, 2023

Pulled and ran this PR. Wanted to note a couple of wrinkles.

Biggest concern: I noticed this also disables the "hide when cursor exits the window" functionality. I've been meaning to post a PR at some point which breaks that out into its own checkbox. Doesn't think seem like a separate piece of functionality?

More of a side note: this PR also means that the title bar also won't go away, even though it's covering the video. I realize this is hard to avoid from a functional standpoint, because the title bar & OSC are currently so coupled. At least there's still one way to hide them both, which is to go to Settings > Control and configure one of the mouse actions to hide the OSC.

Copy link
Contributor

@low-batt low-batt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled the PR locally, built IINA and confirmed the new setting worked.

@low-batt
Copy link
Contributor

@smishralm10 Thanks for making the changes!

@svobs I tried this:

At least there's still one way to hide them both, which is to go to Settings > Control and configure one of the mouse actions to hide the OSC.

But could not get the OSC to hide.

More work is needed in this area. There are outstanding requests for other OSC options. One is to add a Enable OSC like we have for the the OSD to be able to disable showing of the OSC. For example this is useful for people that are controlling IINA using an Apple TV remote.

@uiryuu uiryuu merged commit 2b46ab7 into iina:develop May 30, 2024
@uiryuu
Copy link
Member

uiryuu commented May 30, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option request
4 participants