Fix: cursor lost when dragging clip view edges #4302
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
uiryuu
reviewed
Mar 28, 2023
iina/CropBoxView.swift
Outdated
| return NSMakeRect(x, y, w, h) | ||
| } | ||
|
|
||
| rectTop = makeRect(x, y-2, w, 4) |
There was a problem hiding this comment.
You can call standardized after NSMakeRect, which does the exact same thing as your help function
There was a problem hiding this comment.
Thanks for your advice! Reopened and cleaned up code.
2 tasks
uiryuu
requested changes
Mar 28, 2023
iina/CropBoxView.swift
Outdated
| rectRight = NSMakeRect(x+w-2, y+2, 4, h-4) | ||
| let w = boxRect.size.width | ||
| let h = boxRect.size.height | ||
|
|
uiryuu
approved these changes
Mar 28, 2023
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Start IINA and play a video, open "Quick Settings" panel and select Crop - "Custom...". Drag the right edge over the left boundary and release. The cursor that should appear on the left edge will be lost.
Description:
In
CropBoxView.swift, it uses aboxRect: NSRectto store currently selected clip region, and drew cursor rects around it to capture dragging events.boxRect.sizecan be negative, indicating that it expands southwest from its origin point.However,
NSRect.widthandNSRect.heightare always positive, so the cursor rects (colored in red) are misplaced.Using
NSRect.size.widthandNSRect.size.heightshould fix this problem.