Fix PlayerCore.active not accessed from main thread, #4251 #4278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will: - Change PlayerCore.playbackRestarted to use the main thread to call NowPlayingInfoManager.updateInfo - Remove locking from NowPlayingInfoManager.updateInfo since there is no longer a need to coordinate access from multiple threads - Add comments pointing out the requirement to use the main thread
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
Change
PlayerCore.playbackRestartedto use the main thread to callNowPlayingInfoManager.updateInfoRemove locking from
NowPlayingInfoManager.updateInfosince there is no longer a need to coordinate access from multiple threadsAdd comments pointing out the requirement to use the main thread
I have read CONTRIBUTING.md
This implements/fixes issue Crash due to PlayerCore.active being called outside the main thread #4251.
Description: